Jefffrey commented on code in PR #18750:
URL: https://github.com/apache/datafusion/pull/18750#discussion_r2531972794
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -1336,6 +1337,30 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_get_valid_types_coercible_binary() -> Result<()> {
Review Comment:
On main this test would fail as an input of `LargeBinary` would generate an
output of `BinaryView`, since `LargeBinary` can be casted to `BinaryView` as
per this arm:
https://github.com/apache/datafusion/blob/fad5f8a628acc7db29ffed2c3faf7f1f35da5837/datafusion/common/src/types/native.rs#L256-L258
Now it should be maintained as `LargeBinary`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
