martin-g commented on code in PR #18721:
URL: https://github.com/apache/datafusion/pull/18721#discussion_r2531986541
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -440,7 +441,6 @@ impl FileScanConfigBuilder {
Statistics::new_unknown(file_source.table_schema().file_schema())
Review Comment:
Shouldn't this use the complete table schema (with the partition columns
too) ?
```suggestion
Statistics::new_unknown(file_source.table_schema().table_schema())
```
##########
datafusion/datasource/src/file_scan_config.rs:
##########
Review Comment:
```suggestion
```
##########
datafusion/datasource/src/file_scan_config.rs:
##########
Review Comment:
```suggestion
/// # fn new(table_schema: impl Into<TableSchema>) -> Self { Self
{table_schema: table_schema.into(), schema_adapter_factory: None} }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
