jizezhang commented on issue #18195: URL: https://github.com/apache/datafusion/issues/18195#issuecomment-3538985106
Hi @2010YOUY01 , I put out a short draft PR https://github.com/apache/datafusion/pull/18752 for "fixing `elapsed_compute` baseline metrics not counting issue". The change I made was to track `elapsed_compute` in `FileStream`, which is opened by `DataSourceExec`, though looking over the code base I saw `elapsed_compute` timers being added in different ways across different types of streams, thus not sure what is the best place to track for file scan in this case. Also in terms of testing, I see we have tests for ensuring a metric appears in `explain analyze`, but in this case the metric does exist just the value does not seem correct. How do we usually test for this type of changes? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
