EmilyMatt opened a new pull request, #18809:
URL: https://github.com/apache/datafusion/pull/18809
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
No ticket yet, will update momentarily
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Performance of the Avro reader is currently dismal :(
While going over it, I saw a couple opportunities for improvements, but then
I noticed the lack of support for binary types,
this is something I'd like to tackle early on.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
1. Separated binary/string types to actually respect the output
type(previously they all used the i32 offset variant)
2. Added support for nested binary types.
3. Added support for fixed-binary reads
4. Moved binary/utf8 reads to be copy-on-write, as much as
possible(identified one case where it isn't currently possible with Array type
of Byte element)
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
The new nested support is tested by modifying the existing
`test_complex_list` test, the move to cow is tested via all the current tests
that test strings and binaries.
Added a new test to test fixed type, both in normal and list circumstances.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No, just extended support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
