alamb commented on code in PR #18564:
URL: https://github.com/apache/datafusion/pull/18564#discussion_r2539877876
##########
datafusion/execution/src/runtime_env.rs:
##########
@@ -173,6 +173,80 @@ impl RuntimeEnv {
) -> Result<Arc<dyn EncryptionFactory>> {
self.parquet_encryption_factory_registry.get_factory(id)
}
+
+ /// Returns the current runtime configuration entries
+ pub fn config_entries(&self) -> Vec<ConfigEntry> {
+ use crate::memory_pool::MemoryLimit;
+
+ /// Convert bytes to a human-readable format
+ fn format_byte_size(size: u64) -> String {
+ const GB: u64 = 1024 * 1024 * 1024;
+ const MB: u64 = 1024 * 1024;
+ const KB: u64 = 1024;
+
+ match size {
+ s if s >= GB => format!("{}G", s / GB),
+ s if s >= MB => format!("{}M", s / MB),
+ s if s >= KB => format!("{}K", s / KB),
+ s => format!("{s}"),
+ }
+ }
+
+ let memory_limit_value = match self.memory_pool.memory_limit() {
+ MemoryLimit::Finite(size) => Some(format_byte_size(
+ size.try_into()
+ .expect("Memory limit size conversion failed"),
+ )),
+ MemoryLimit::Infinite => Some("unlimited".to_string()),
+ MemoryLimit::Unknown => None,
+ };
+
+ let max_temp_dir_size = self.disk_manager.max_temp_directory_size();
+ let max_temp_dir_value = format_byte_size(max_temp_dir_size);
+
+ let temp_paths = self.disk_manager.temp_dir_paths();
+ let temp_dir_value = if temp_paths.is_empty() {
+ None
+ } else {
+ Some(
+ temp_paths
+ .iter()
+ .map(|p| p.display().to_string())
+ .collect::<Vec<_>>()
+ .join(","),
+ )
+ };
+
+ let metadata_cache_limit =
self.cache_manager.get_metadata_cache_limit();
+ let metadata_cache_value = format_byte_size(
+ metadata_cache_limit
+ .try_into()
+ .expect("Metadata cache size conversion failed"),
+ );
+
+ vec![
Review Comment:
this looks very similar to the list in RuntimeEnvBuilder
I wonder is there some way to avoid the duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
