timsaucer commented on issue #18477: URL: https://github.com/apache/datafusion/issues/18477#issuecomment-3550042932
In https://github.com/apache/datafusion/pull/18813 I took a first stab at what this might look like. This is impactful to the work I've been doing for the FFI crates and I think it might make my life vastly simpler if we have it or something like it implemented. I'm not crazy about how a lot of the methods just mirror those in the `PhysicalExtensionCodec` but what this does do is give us a mutable wrapper around those so we can do tracking and other things. I don't think we can just update the `PhysicalExtensionCodec` with `&mut self` because it appears there is a use case where we pass around `Arc<dyn PhysicalExtensionCodec>` and also `Arc<TaskContext>`. In my experimentation I found that to implement mutable version of `PhysicalExtensionCodec` I had to end up cloning `TaskContext`, which isn't ideal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
