BlakeOrth commented on code in PR #18855:
URL: https://github.com/apache/datafusion/pull/18855#discussion_r2548174534
##########
datafusion/execution/src/cache/cache_manager.rs:
##########
@@ -140,7 +155,17 @@ impl CacheManager {
let file_statistic_cache =
config.table_files_statistics_cache.as_ref().map(Arc::clone);
- let list_files_cache =
config.list_files_cache.as_ref().map(Arc::clone);
+ let list_files_cache = config
+ .list_files_cache
+ .as_ref()
+ .map(Arc::clone)
+ .unwrap_or_else(|| {
+ Arc::new(DefaultListFilesCache::new(
+ // TODO: config
+ 512 * 1024,
+ Duration::new(600, 0),
Review Comment:
This POC doesn't implement any of the user configuration. This seems like a
good opportunity to divide the work on this effort! We could get the base
`DefaultListFilesCache` approved for merge without user configuration, and
leave it disabled, and user configuration could be added by anyone who wants to
contribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
