pepijnve commented on PR #18872: URL: https://github.com/apache/datafusion/pull/18872#issuecomment-3564055567
> Thanks @pepijnve, I ran those tests on main now and their passed 🤔 I would expect them fail without this PR change? No, that's expected. The code was computing the correct result in spite of this. What was happens on `main` is that at https://github.com/apache/datafusion/pull/18872/files#diff-ac23ff0fe78acd71875341026dd5907736e3e3f49e2c398a69e6b33cb6394ae8L869 the null count is `0` so the null handling code path is not taken. The result is that the rows which have an effective null value are tested for equality against each when value. That's pointless since it will be falsy each time. With this change the null handling code path is taken and the null values get filtered out before reaching the when branch handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
