Jefffrey commented on code in PR #18839:
URL: https://github.com/apache/datafusion/pull/18839#discussion_r2551637050
##########
datafusion/functions-nested/src/string.rs:
##########
@@ -607,8 +607,8 @@ where
fn string_to_array_inner_3<'a, StringArrType, DelimiterArrType,
StringBuilderType>(
args: &'a [ArrayRef],
- string_array: StringArrType,
- delimiter_array: DelimiterArrType,
+ string_array: &StringArrType,
+ delimiter_array: &DelimiterArrType,
Review Comment:
Thanks for checking this. I still find it odd and see it as a false positive
by clippy, but I guess its easier to just follow the lint than manually
ignoring it 🙁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
