iffyio commented on code in PR #2100:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2100#discussion_r2552349625
##########
src/parser/mod.rs:
##########
@@ -17225,66 +17229,84 @@ impl<'a> Parser<'a> {
self.expect_keyword_is(Keyword::THEN)?;
+ macro_rules! not_allowed {
Review Comment:
maybe we can keep this inlined as before, alternative would be to pull it
out to a function but that might not be worth it. But in generally we'd ideally
avoid custom macros where possible since those are harder to maintain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
