Nithurshen opened a new pull request, #18929:
URL: https://github.com/apache/datafusion/pull/18929
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #16293
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently, DataFusion fails to consume Substrait plans that utilize
`like_match`, `like_imatch`, or their negated variants (`like_not_match`,
`like_not_imatch`). This results in a panic with `DataFusion error: This
feature is not implemented: Unsupported function name: "like_match"` during
round-trip planning.
This PR implements the missing mapping logic in the Substrait consumer to
correctly translate these function names into DataFusion `Expr::Like`
expressions.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Updated `BuiltinExprBuilder` in `scalar_function.rs` to recognize:
- `like_match` (LIKE)
- `like_imatch` (ILIKE)
- `like_not_match` (NOT LIKE)
- `like_not_imatch` (NOT ILIKE)
- Modified the internal `build_like_expr` helper to accept a `negated`
boolean flag (previously hardcoded to `false`).
- Added a new unit test `test_like_match_conversion` to verify the correct
conversion of these functions and their arguments.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes. I added a new unit test `test_like_match_conversion` in
`datafusion/substrait/src/logical_plan/consumer/expr/scalar_function.rs`.
This test explicitly constructs Substrait plans for `like_match` and
`like_not_match` and asserts that they are consumed into correct DataFusion
`Expr::Like` variants with the appropriate `negated` and `case_insensitive`
flags.
**Note: Verification was done via unit test rather than the standard
`sqllogictest` suite because `predicates.slt` was experiencing unrelated
environment-specific failures locally.**
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
- No breaking changes.
- Users relying on Substrait round-trips for LIKE/ILIKE expressions will now
see these queries succeed instead of failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
