xitep commented on PR #2101: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2101#issuecomment-3574612663
* yeah, i think starting an `OracleDialect` would definitely be the proper way forward. (it's just a much broader change than i think i can manage right now.) * wrt: #2103: i think that is _not_ (very) oracle specific. (truth is, the "AS" keyword will break the queries on oracle DBs; and `OracleDialect` would surely need to do something about it.) but primarily i see the change primarily as a step towards "...recover(ing) the original SQL text..." (README.md.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
