adriangb commented on code in PR #18627:
URL: https://github.com/apache/datafusion/pull/18627#discussion_r2562816500
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -1114,252 +1092,6 @@ impl DisplayAs for FileScanConfig {
}
}
-/// A helper that projects partition columns into the file record batches.
-///
-/// One interesting trick is the usage of a cache for the key buffers of the
partition column
-/// dictionaries. Indeed, the partition columns are constant, so the
dictionaries that represent them
-/// have all their keys equal to 0. This enables us to re-use the same
"all-zero" buffer across batches,
-/// which makes the space consumption of the partition columns O(batch_size)
instead of O(record_count).
-pub struct PartitionColumnProjector {
Review Comment:
We mostly handled the optimizations globally already:
https://github.com/apache/datafusion/pull/16789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
