Jefffrey commented on code in PR #18691:
URL: https://github.com/apache/datafusion/pull/18691#discussion_r2563800135
##########
datafusion-cli/tests/cli_integration.rs:
##########
@@ -157,6 +157,10 @@ fn init() {
"change_format_version",
["--file", "tests/sql/types_format.sql", "-q"],
)]
+#[case::fetch_not_supported(
Review Comment:
We could put this as a test in SLT instead and avoid needing to add the snap
file
##########
docs/source/user-guide/sql/select.md:
##########
@@ -306,6 +306,8 @@ SELECT age, person FROM table ORDER BY age, person DESC;
Limits the number of rows to be a maximum of `count` rows. `count` should be a
non-negative integer.
+DataFusion does not currently support the SQL `FETCH` clause. Use `LIMIT` to
constrain the number of returned rows instead.
Review Comment:
Personally I'm of the mind to omit this from documentation; I prefer to
state only what we do support instead of enumerating what we don't.
##########
datafusion/sql/src/query.rs:
##########
@@ -46,17 +46,31 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
let mut query_plan_context = outer_planner_context.clone();
let planner_context = &mut query_plan_context;
- if let Some(with) = query.with {
+ let Query {
+ with,
+ body,
+ order_by,
+ limit_clause,
+ pipe_operators,
+ fetch,
+ ..
Review Comment:
Perhaps we shouldn't have `..` here so we can catch any more features that
come in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
