kumarUjjawal commented on code in PR #18979:
URL: https://github.com/apache/datafusion/pull/18979#discussion_r2572332264
##########
datafusion/sqllogictest/test_files/scalar.slt:
##########
@@ -317,6 +317,50 @@ select ceil(100.1234, 1)
query error DataFusion error: This feature is not implemented: CEIL with
datetime is not supported
select ceil(100.1234 to year)
+# ceil with decimal argument
+query RRRR
+select
+ ceil(arrow_cast(1.23,'Decimal128(10,2)')),
+ ceil(arrow_cast(-1.23,'Decimal128(10,2)')),
+ ceil(arrow_cast(123.00,'Decimal128(10,2)')),
+ ceil(arrow_cast(-123.00,'Decimal128(10,2)'));
+----
+2 -1 123 -123
+
+# ceil with decimal32 argument (ensure decimal output)
+query TTTTTTTT
+select
+ arrow_typeof(ceil(arrow_cast(9.01,'Decimal32(7,2)'))),
+ arrow_cast(ceil(arrow_cast(9.01,'Decimal32(7,2)')), 'Utf8'),
+ arrow_typeof(ceil(arrow_cast(-9.01,'Decimal32(7,2)'))),
+ arrow_cast(ceil(arrow_cast(-9.01,'Decimal32(7,2)')), 'Utf8'),
+ arrow_typeof(ceil(arrow_cast(10.00,'Decimal32(7,2)'))),
+ arrow_cast(ceil(arrow_cast(10.00,'Decimal32(7,2)')), 'Utf8'),
+ arrow_typeof(ceil(arrow_cast(-0.99,'Decimal32(7,2)'))),
+ arrow_cast(ceil(arrow_cast(-0.99,'Decimal32(7,2)')), 'Utf8');
+----
+Decimal32(7, 2) 10.00 Decimal32(7, 2) -9.00 Decimal32(7, 2) 10.00 Decimal32(7,
2) 0.00
+
+# ceil with decimal64 zero scale
+query TTTT
+select
+ arrow_typeof(ceil(arrow_cast(123456789,'Decimal64(18,0)'))),
+ arrow_cast(ceil(arrow_cast(123456789,'Decimal64(18,0)')), 'Utf8'),
+ arrow_typeof(ceil(arrow_cast(-987654321,'Decimal64(18,0)'))),
+ arrow_cast(ceil(arrow_cast(-987654321,'Decimal64(18,0)')), 'Utf8');
+----
+Decimal64(18, 0) 123456789 Decimal64(18, 0) -987654321
+
+# ceil with decimal256 argument
+query TTTT
+select
+
arrow_typeof(ceil(arrow_cast('9999999999999999999999999999999999.01','Decimal256(38,2)'))),
+
arrow_cast(ceil(arrow_cast('9999999999999999999999999999999999.01','Decimal256(38,2)')),
'Utf8'),
+
arrow_typeof(ceil(arrow_cast('-9999999999999999999999999999999999.01','Decimal256(38,2)'))),
+
arrow_cast(ceil(arrow_cast('-9999999999999999999999999999999999.01','Decimal256(38,2)')),
'Utf8');
+----
+Decimal256(38, 2) 10000000000000000000000000000000000.00 Decimal256(38, 2)
-9999999999999999999999999999999999.00
Review Comment:
@martin-g is this the right way to handle this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
