nuno-faria commented on PR #1311:
URL: 
https://github.com/apache/datafusion-python/pull/1311#issuecomment-3591839433

   Thanks @kosiew, I merged the PR.
   
   Just a side note in the `read_stream` function:
   ```py
   def read_stream():
       ...
       try:
           ...
       except KeyboardInterrupt:
           read_exception.append(KeyboardInterrupt)
       except Exception as e:
           read_exception.append(e)
   ```
   
   The `except KeyboardInterrupt:` is not triggered, but rather the `except 
Exception as e:`, as it throws an `External error: KeyboardInterrupt`, which is 
what I think @timsaucer was expecting here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to