adriangb commented on code in PR #18998:
URL: https://github.com/apache/datafusion/pull/18998#discussion_r2573516918
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -1275,143 +1273,4 @@ mod test {
}
}
}
-
- #[tokio::test]
- async fn test_custom_schema_adapter_no_rewriter() {
- // Make a hardcoded schema adapter that adds a new column "b" with
default value 0.0
- // and converts the first column "a" from Int32 to UInt64.
Review Comment:
Same here I think this test is no longer relevant
##########
datafusion/core/tests/parquet/schema_adapter.rs:
##########
@@ -293,36 +293,8 @@ async fn
test_custom_schema_adapter_and_custom_expression_adapter() {
];
assert_batches_eq!(expected, &batches);
- // Test using a custom schema adapter and no explicit physical expr adapter
- // This should use the custom schema adapter both for projections and
predicate pushdown
Review Comment:
Removing this because it's no longer true. SchemaAdapter is not used for
predicate pushdown.
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -740,6 +740,101 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_cast_timestamp_with_timezone_to_timestamp() -> Result<()> {
Review Comment:
These ended up not being necessary (the bug was elsewhere in my changes) but
I think it's good coverage anyway so leaving it in here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
