alamb commented on code in PR #19003:
URL: https://github.com/apache/datafusion/pull/19003#discussion_r2575010134
##########
datafusion/common/src/config.rs:
##########
@@ -694,6 +694,12 @@ config_namespace! {
/// the filters are applied in the same order as written in the query
pub reorder_filters: bool, default = false
+ /// (reading) Force the use of RowSelections for filter results, when
+ /// pushdown_filters is enabled. If false, the reader will
automatically
+ /// choose between a RowSelection and a Bitmap based on the number and
+ /// pattern of selected rows.
+ pub force_filter_selections: bool, default = false
Review Comment:
@rluvaton suggests in
https://github.com/apache/datafusion/pull/18820#discussion_r2564201623:
> What do you think of making it an enum instead to allow for future
additions without breaking changes?
>
> (that enum should also be non exhaustive to avoid adding a variant a
breaking change)
>
> I also see that the `with_row_selection_policy` already accept enum.
>
> making it an enum also allow to force mask or configure the threshold in
the auto policy. this is also useful for testing to force specific path when
creating a reproduction test for a bug
I personally think it is better as a flag (escape valve) as I don't forsee
any reason to try and tune the parameters but would be happy to hear other
opinions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
