alamb commented on code in PR #18209:
URL: https://github.com/apache/datafusion/pull/18209#discussion_r2578409578


##########
benchmarks/src/tpch/run.rs:
##########
@@ -92,6 +92,15 @@ pub struct RunOpt {
     #[structopt(short = "j", long = "prefer_hash_join", default_value = 
"true")]
     prefer_hash_join: BoolDefaultTrue,
 
+    /// If true then Piecewise Merge Join can be used, if false then it will 
opt for Nested Loop Join
+    /// True by default.
+    #[structopt(
+        short = "j",

Review Comment:
   I believe this causes a bug as the `-j` is duplicated with 
`prefer_hash_join` above. 
   
   Here is a PR to fix:
   - https://github.com/apache/datafusion/pull/19033



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to