LiaCastaneda commented on PR #18938: URL: https://github.com/apache/datafusion/pull/18938#issuecomment-3598650556
> I ask because I think this approach is what we actually want. Yeah, sorry for the confusion -- I switched the approach to exact/inexact/unsupported just as an alternative since it was getting really hard to get `is_used` fully right. I will open a separate PR for `is_used` to avoid confusion, I will attempt to solve the bug (or at least find out what's going on) between today and tomorrow. > This is interesting. Could it indicate a bug? I took a look the other day, and the thing is that for some reason the strong count is not accounting for the leaf node that supposedly also holds a reference to `DynamicFilterPhysicalExpr`. 🤔 ``` [partition 0] Arc count at execution: 1 [partition 0] Is used: false [partition 1] Arc count at execution: 2 ``` The 1 -> 2 strong count is actually expected here because the first partition creates the SharedBuildAccumulator which also holds a reference to the DynamicFilterPhysicalExpr, but if the hash join + the leaf keep the ref (which is what we should be seeing) I would have expected to see something like: ``` [partition 0] Arc count at execution: 2 [partition 0] Is used: false [partition 1] Arc count at execution: 3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
