atifShaiKh0 commented on issue #19039: URL: https://github.com/apache/datafusion/issues/19039#issuecomment-3599843016
Hi @alamb, I would like to work on this issue. I’ve reviewed the current `CreateExternalTable` struct and the use cases where many default fields are repeated. Adding a `CreateExternalTableBuilder` makes sense to simplify construction and make overridden fields clearer. Before I start, could you confirm two things: 1. Should the builder enforce required fields through its constructor (e.g., name, location, file_type, schema)? 2. Should the builder live in the same module as `CreateExternalTable`, or would you prefer placing it in a separate `builder` module? If this approach aligns with your expectations, I’m happy to proceed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
