2010YOUY01 commented on code in PR #17863:
URL: https://github.com/apache/datafusion/pull/17863#discussion_r2579408344
##########
.github/workflows/dev.yml:
##########
@@ -57,3 +58,15 @@ jobs:
README.md \
CONTRIBUTING.md
git diff --exit-code
+
+ typos:
+ name: Spell Check with Typos
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ persist-credentials: false
+ - name: Install typos-cli
+ run: cargo install typos-cli --locked --version 1.37.0
Review Comment:
Personally, I don’t think we want to invest too much long-term effort in
maintaining this tool. Even automatic upgrades require manual fixes. Probably
it's okay to keep its version locked?
`typos-cli` has rule-based implementation, so it inherently has many false
positives and negatives. I hope we can eventually rely on AI-based code review
tools to catch typos instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
