xudong963 commented on PR #18970: URL: https://github.com/apache/datafusion/pull/18970#issuecomment-3600917126
> Thank you @xudong963 and @martin-g > > I think prior to releasing this code we should make the following changes: > > 1. Avoid explicit recursion in not simplification (and instead use the tree node API) > 2. Avoid the potential infinite loop > > It would be nice to make them as part of this PR, but I also think it would be ok to do it as a follow on > > Other things I think would be good to do but not strictly necessary: > > 1. Move the tests to the public interface (PhysicalExprSimplifier) > 2. Avoid duplications of `Operator::negate` Thanks @alamb. I addressed all suggestions in the latest commit https://github.com/apache/datafusion/pull/18970/commits/27c4ef18b9bd3ac0beddcc816041972903a47144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
