martin-g commented on code in PR #19041:
URL: https://github.com/apache/datafusion/pull/19041#discussion_r2581254522
##########
datafusion/physical-plan/src/sorts/stream.rs:
##########
@@ -181,7 +181,7 @@ impl RowCursorStream {
// track the memory in the newly created Rows.
let mut rows_reservation = self.reservation.new_empty();
- rows_reservation.try_grow(rows.size())?;
+ rows_reservation.grow(rows.size());
Review Comment:
Why ?
`new_empty()` returns a MemoryReservation with size=0 but the `registration`
is shared (`Arc::clone()`), so the pool may not have enough space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
