alamb commented on code in PR #19035:
URL: https://github.com/apache/datafusion/pull/19035#discussion_r2585591534
##########
benchmarks/bench.sh:
##########
@@ -548,20 +544,19 @@ data_tpch() {
echo "Internal error: Scale factor not specified"
exit 1
fi
+ FORMAT=$2
Review Comment:
Ah, I see what you are saying now - there are several other calls to
data_tpch that don't pass the format argument here
https://github.com/alamb/datafusion/blob/21a0237a1b96cf42bd96e93e6fc184a8e320138f/benchmarks/bench.sh#L298-L308
eg
```sh
sort_tpch)
# same data as for tpch
data_tpch "1"
;;
sort_tpch10)
# same data as for tpch10
data_tpch "10"
;;
topk_tpch)
# same data as for tpch
data_tpch "1"
;;
nlj)
```
I will update those calls to explicitly pass in a format as I think that
will make it clear what is going on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
