mbutrovich commented on PR #18875: URL: https://github.com/apache/datafusion/pull/18875#issuecomment-3608977991
> some of the `debug_assert` are very very cheap that I think we should do regular assert. for example: > > ``` > debug_assert_eq!( > indices.len(), > indices_len, > "indices.len() should match indices_len parameter" > ); > ``` I might remove some. They were mostly to help me understand control flow as I was learning the SMJ state machine: I'd try to codify my understanding with `debug_assert`s as I went, and if I broke something or otherwise changed behavior that I was convinced was an invariant, I'd have good safeguards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
