Jefffrey commented on code in PR #19068:
URL: https://github.com/apache/datafusion/pull/19068#discussion_r2586959102
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -19,7 +19,7 @@
//! file sources.
use crate::file_groups::FileGroup;
-#[allow(unused_imports)]
+#[expect(unused_imports)]
use crate::schema_adapter::SchemaAdapterFactory;
Review Comment:
```suggestion
```
Could we remove the import?
##########
datafusion/datasource-parquet/src/reader.rs:
##########
@@ -289,7 +289,9 @@ impl AsyncFileReader for CachedParquetFileReader {
fn get_metadata<'a>(
&'a mut self,
- #[allow(unused_variables)] options: Option<&'a ArrowReaderOptions>,
+ #[cfg_attr(not(feature = "parquet_encryption"),
allow(clippy::allow_attributes))]
+ #[cfg_attr(not(feature = "parquet_encryption"),
allow(unused_variables))]
Review Comment:
```suggestion
#[cfg_attr(not(feature = "parquet_encryption"),
expect(unused_variables))]
```
Per my comment here:
https://github.com/apache/datafusion/issues/18881#issuecomment-3567846975
##########
datafusion/doc/src/lib.rs:
##########
@@ -30,7 +30,7 @@ pub use udaf::aggregate_doc_sections;
pub use udf::scalar_doc_sections;
pub use udwf::window_doc_sections;
-#[allow(rustdoc::broken_intra_doc_links)]
+#[expect(rustdoc::broken_intra_doc_links)]
Review Comment:
Could we also fix this instead of expecting it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
