Omega359 commented on code in PR #19078:
URL: https://github.com/apache/datafusion/pull/19078#discussion_r2589323463
##########
datafusion/functions/src/datetime/to_unixtime.rs:
##########
@@ -114,9 +114,11 @@ impl ScalarUDFImpl for ToUnixtimeFunc {
DataType::Timestamp(_, tz) => arg_args[0]
.cast_to(&DataType::Timestamp(TimeUnit::Second, tz), None)?
.cast_to(&DataType::Int64, None),
- DataType::Utf8 => ToTimestampSecondsFunc::new()
- .invoke_with_args(args)?
- .cast_to(&DataType::Int64, None),
+ DataType::Utf8 => {
Review Comment:
Most likely, but that should be another issue - I didn't want to change
things too much in the PR. There are similar issues with data types in
to_timestamp (no Uint types, etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
