willemv commented on code in PR #19077:
URL: https://github.com/apache/datafusion/pull/19077#discussion_r2591657667
##########
datafusion/functions/src/string/starts_with.rs:
##########
@@ -132,15 +132,18 @@ impl ScalarUDFImpl for StartsWithFunc {
) -> Result<ExprSimplifyResult> {
if let Expr::Literal(scalar_value, _) = &args[1] {
// Convert starts_with(col, 'prefix') to col LIKE 'prefix%' with
proper escaping
- // Example: starts_with(col, 'ja%') -> col LIKE 'ja\%%'
- // 1. 'ja%' (input pattern)
- // 2. 'ja\%' (escape special char '%')
- // 3. 'ja\%%' (add suffix for starts_with)
+ // Example: starts_with(col, 'j_a%') -> col LIKE 'j\_a\%%'
Review Comment:
Indeed, I adjusted the steps below it but not this line ...
Fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
