cj-zhukov commented on code in PR #18946: URL: https://github.com/apache/datafusion/pull/18946#discussion_r2592037349
########## ci/scripts/rust_example.sh: ########## @@ -22,6 +22,15 @@ set -e export CARGO_PROFILE_CI_OPT_LEVEL="s" export CARGO_PROFILE_CI_STRIP=true +# Remove leftover files inside test_* directories inside datafusion-examples/ Review Comment: You're right that the shell script cleanup works, but in this case the underlying issue is that the example writes into a relative path like `./datafusion-examples/test_parquet/` . When the example runs under `datafusion-examples/examples/`, this creates a nested `datafusion-examples/` directory, which the script then mistakenly treats as another example group. To avoid this class of problems entirely, I think it’s cleaner and more robust for the example to write into a tempfile rather than modifying directories inside the repository. This keeps examples self-contained, removes unintended side effects, and lets us simplify the shell script. I can remove the cleanup logic from the script and keep the example using a temp directory. Let me know if you'd prefer a different approach, but this seems like the cleanest long-term fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
