geoffreyclaude commented on code in PR #17843:
URL: https://github.com/apache/datafusion/pull/17843#discussion_r2593089540
##########
datafusion/sql/src/relation/mod.rs:
##########
@@ -24,19 +24,119 @@ use datafusion_common::{
not_impl_err, plan_err, DFSchema, Diagnostic, Result, Span, Spans,
TableReference,
};
use datafusion_expr::builder::subquery_alias;
+use datafusion_expr::planner::{
+ PlannedRelation, RelationPlannerContext, RelationPlanning,
+};
use datafusion_expr::{expr::Unnest, Expr, LogicalPlan, LogicalPlanBuilder};
use datafusion_expr::{Subquery, SubqueryAlias};
use sqlparser::ast::{FunctionArg, FunctionArgExpr, Spanned, TableFactor};
mod join;
+struct SqlToRelRelationContext<'a, 'b, S: ContextProvider> {
+ planner: &'a SqlToRel<'b, S>,
+ planner_context: &'a mut PlannerContext,
+}
+
+// Implement RelationPlannerContext
+impl<'a, 'b, S: ContextProvider> RelationPlannerContext
+ for SqlToRelRelationContext<'a, 'b, S>
+{
+ fn context_provider(&self) -> &dyn ContextProvider {
+ self.planner.context_provider
+ }
+
+ fn plan(&mut self, relation: TableFactor) -> Result<LogicalPlan> {
+ self.planner.create_relation(relation, self.planner_context)
+ }
+
+ fn sql_to_expr(
+ &mut self,
+ expr: sqlparser::ast::Expr,
+ schema: &DFSchema,
+ ) -> Result<Expr> {
+ self.planner.sql_to_expr(expr, schema, self.planner_context)
+ }
+
+ fn sql_expr_to_logical_expr(
+ &mut self,
+ expr: sqlparser::ast::Expr,
+ schema: &DFSchema,
+ ) -> Result<Expr> {
+ self.planner
+ .sql_expr_to_logical_expr(expr, schema, self.planner_context)
+ }
+
+ fn normalize_ident(&self, ident: sqlparser::ast::Ident) -> String {
+ self.planner.ident_normalizer.normalize(ident)
+ }
+
+ fn object_name_to_table_reference(
+ &self,
+ name: sqlparser::ast::ObjectName,
+ ) -> Result<TableReference> {
+ self.planner.object_name_to_table_reference(name)
+ }
+}
+
impl<S: ContextProvider> SqlToRel<'_, S> {
/// Create a `LogicalPlan` that scans the named relation
fn create_relation(
&self,
relation: TableFactor,
planner_context: &mut PlannerContext,
) -> Result<LogicalPlan> {
+ let planned_relation =
Review Comment:
Updated method comment to:
```rust
/// Create a `LogicalPlan` that scans the named relation.
///
/// First tries any registered extension planners. If no extension
handles
/// the relation, falls back to the default planner.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
