andygrove commented on code in PR #2826:
URL: https://github.com/apache/datafusion-comet/pull/2826#discussion_r2593910903
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -1471,6 +1472,168 @@ class CometAggregateSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("ANSI support for decimal sum - null test") {
+ Seq(true, false).foreach { ansiEnabled =>
+ withSQLConf(
+ SQLConf.ANSI_ENABLED.key -> ansiEnabled.toString,
+ CometConf.getExprAllowIncompatConfigKey(classOf[Sum]) -> "true") {
Review Comment:
I don't think these tests need to set
`CometConf.getExprAllowIncompatConfigKey(classOf[Sum]) -> "true"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
