alamb commented on issue #19114: URL: https://github.com/apache/datafusion/issues/19114#issuecomment-3618699526
Suggestion for implementation: https://github.com/apache/datafusion/pull/18855#discussion_r2594059602 > One classic way is to pass a template / object to the cache to provide the current time, rather than calling std::instant::now() directly > > Then the tests can use a mock version of the time provider (that is explicitly controlled) and the normal code uses std::Instant::now > > The downside of this approach is that it does mean what is tested has some differences than what is in production -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
