Jefffrey commented on code in PR #19118:
URL: https://github.com/apache/datafusion/pull/19118#discussion_r2595922839
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -1972,6 +1984,38 @@ impl protobuf::PhysicalPlanNode {
Ok(Arc::new(CooperativeExec::new(input)))
}
+ fn try_into_async_func_physical_plan(
+ &self,
+ async_func: &protobuf::AsyncFuncExecNode,
+ ctx: &TaskContext,
+ extension_codec: &dyn PhysicalExtensionCodec,
+ ) -> Result<Arc<dyn ExecutionPlan>> {
+ let input: Arc<dyn ExecutionPlan> =
+ into_physical_plan(&async_func.input, ctx, extension_codec)?;
+
+ let async_exprs = async_func
+ .async_exprs
+ .iter()
+ .zip(async_func.async_expr_names.iter())
Review Comment:
I wonder if we should check both vecs are of same length here to be
defensive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
