danielhumanmod commented on PR #2831: URL: https://github.com/apache/datafusion-comet/pull/2831#issuecomment-3623432768
Hey @coderfender @martin-g , I’ve addressed the comments and refactored the Rust implementation based on the approach used in the similar UDF [regexp_replace](https://github.com/apache/datafusion/blob/fc6d0a4287ab8054d9f56c9ce0a13ffc0ec3c170/datafusion/functions/src/regex/regexpreplace.rs#L88) in DataFusion. Whenever you have time, I’d appreciate another look. Thanks again for the helpful feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
