geoffreyclaude opened a new pull request, #19204: URL: https://github.com/apache/datafusion/pull/19204
## Which issue does this PR close? N/A - benchmark fix discovered during performance analysis of #18832. ## Rationale for this change The `in_list` benchmark (introduced in #4068) had inverted null generation logic: `null_percent=0` was producing 100% nulls instead of 0% nulls. ## What changes are included in this PR? Fix the `random_bool(null_percent).then(...)` pattern to use `random_bool(1.0 - null_percent)` so that `null_percent` correctly represents the percentage of null values. ## Are these changes tested? Benchmark-only change. Verified by running the benchmark and observing expected performance characteristics. ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
