geoffreyclaude commented on PR #18832: URL: https://github.com/apache/datafusion/pull/18832#issuecomment-3625983917
Another general comment, on the implementation this time: hashing seems overkill and probably overly expensive for small-ish simple type lists. Have you considered sorting the `InList` and doing a binary search? Even for 1024 elements in the `InList` that would be at most 10 comparisons all in L1 cache, which could be orders of magnitude faster that the overhead of hashing. To validate with the new fixed benchmarks of course! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
