adriangb commented on PR #19129: URL: https://github.com/apache/datafusion/pull/19129#issuecomment-3627139892
> This looks interesting -- the only thing I don't understand is why the previously added constant folding expression doesn't cover this It does overlap with that work. My reasoning for doing it in two places was that these are two disconnected APIs (i.e. we don't require you to run the simplifier before calling `PruningPredicate::try_new`) and there may be teams using one without the other. The alternative to this would be to recommend calling the simplifier before calling `PruningPredicate` and not support this in `PruningPredicate`? If so I can refactor to recommend that and do so in the tests (i.e. verify that the integration works without implementing the feature here as well). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
