alamb commented on code in PR #19054:
URL: https://github.com/apache/datafusion/pull/19054#discussion_r2599700471
##########
datafusion/catalog-listing/src/table.rs:
##########
@@ -255,7 +255,7 @@ impl ListingTable {
/// multiple times in the same session.
///
/// If `None`, creates a new [`DefaultFileStatisticsCache`] scoped to this
query.
- pub fn with_cache(mut self, cache: Option<FileStatisticsCache>) -> Self {
+ pub fn with_cache(mut self, cache: Option<Arc<dyn FileStatisticsCache>>)
-> Self {
Review Comment:
technically this is an API change, but I think it is a good one and makes
the FileStatisticsCache consistent with the rest-- will mark the PR as API
change
##########
datafusion-cli/src/main.rs:
##########
@@ -631,4 +647,56 @@ mod tests {
Ok(())
}
+
+ #[tokio::test]
+ async fn test_statistics_cache() -> Result<(), DataFusionError> {
+ let file_statistics_cache =
Arc::new(DefaultFileStatisticsCache::default());
Review Comment:
This will not be necessary after
https://github.com/apache/datafusion/issues/19217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
