chakkk309 commented on code in PR #19133:
URL: https://github.com/apache/datafusion/pull/19133#discussion_r2602923275
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -3235,6 +3235,7 @@ impl PartialOrd for Analyze {
// TODO(clippy): This clippy `allow` should be removed if
// the manual `PartialEq` is removed in favor of a derive.
// (see `PartialEq` the impl for details.)
+#[allow(clippy::allow_attributes)]
Review Comment:
Hi, if we change `#[allow(clippy::derived_hash_with_manual_eq)]` to
`#[expect(clippy::derived_hash_with_manual_eq)]`, that will be the error:
```
error: you are deriving `Hash` but have implemented `PartialEq` explicitly
--> datafusion/expr/src/logical_plan/plan.rs:3239:28
|
3239 | #[derive(Debug, Clone, Eq, Hash)]
| ^^^^
|
note: `PartialEq` implemented here
--> datafusion/expr/src/logical_plan/plan.rs:3248:1
|
3248 | impl PartialEq for Extension {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit
https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#derived_hash_with_manual_eq
= note: `#[deny(clippy::derived_hash_with_manual_eq)]` on by default
warning: this lint expectation is unfulfilled
--> datafusion/expr/src/logical_plan/plan.rs:3238:10
|
3238 | #[expect(clippy::derived_hash_with_manual_eq)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unfulfilled_lint_expectations)]` on by default
warning: `datafusion-expr` (lib) generated 1 warning
error: could not compile `datafusion-expr` (lib) due to 1 previous error;
1 warning emitted
```
Seems like expect can't override clippy's default deny-level lint
`derived_hash_with_manual_eq` ：（, so maybe we need allow with a policy override
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
