adriangb commented on code in PR #19128:
URL: https://github.com/apache/datafusion/pull/19128#discussion_r2603201326
##########
datafusion/physical-expr-adapter/src/schema_rewriter.rs:
##########
@@ -34,6 +35,35 @@ use datafusion_physical_expr::{
};
use datafusion_physical_expr_common::physical_expr::PhysicalExpr;
+/// Replace column references in the given physical expression with literal
values.
+///
+/// This is used to substitute partition column references with their literal
values during expression rewriting.
Review Comment:
Great point! I'm going to update
`datafusion-examples/examples/custom_data_source/default_column_values.rs` to
use this new method precisely for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
