timsaucer commented on PR #19234: URL: https://github.com/apache/datafusion/pull/19234#issuecomment-3636270153
When I was testing this with the FFI work previously I found switching from `&dyn PhysicalExtensionCodec` to using generics on the functions was a blocker for the FFI work. However I moved away from using the physical codec in my work and I only use the logical codec. As long as we don't make the same changes in the logical codec, it shouldn't be a blocker for our existing work. I *could* see a potential for someone who wants to use the FFI_PhysicalExtensionCodec because it doesn't know the concrete type. It *feels* not ideal to then have two different code structures for the logical and physical codecs. Do you think there's a real performance enhancement to gain by using generics over keeping it with passing `&dyn`? Is it really about how many methods people need to implement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
