adriangb commented on PR #19111: URL: https://github.com/apache/datafusion/pull/19111#issuecomment-3637991814
Benchmarks generally look *great*! The only slowdown >10% I see is `│ QQuery 9 │ 96.56 ms │ 108.39 ms │ 1.12x slower │` for `tpch_mem_sf1` Those are smaller / faster runs, I think they tend to be more noisy. I think this is noise. And on the balance there's other slower queries that became 1.94x faster, so on the balance this is a huge perf improvement. With that I'm going to go ahead and merge this 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
