andygrove commented on code in PR #2879:
URL: https://github.com/apache/datafusion-comet/pull/2879#discussion_r2612062090
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -132,22 +133,12 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] with Com
}
}
- private def isDynamicPruningFilter(e: Expression): Boolean =
- e.exists(_.isInstanceOf[PlanExpression[_]])
-
private def transformV1Scan(scanExec: FileSourceScanExec): SparkPlan = {
- if (COMET_DPP_FALLBACK_ENABLED.get() &&
- scanExec.partitionFilters.exists(isDynamicPruningFilter)) {
- return withInfo(scanExec, "Dynamic Partition Pruning is not supported")
- }
-
scanExec.relation match {
case r: HadoopFsRelation =>
- val fallbackReasons = new ListBuffer[String]()
Review Comment:
The code no longer accumulates fallback reasons in a list, but just calls
`withInfo` for each fallback so that we accumulate them directly on the
operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
