ethan-tyler commented on code in PR #19252:
URL: https://github.com/apache/datafusion/pull/19252#discussion_r2615407369
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -885,7 +898,7 @@ impl AggregateExec {
};
match self.mode {
AggregateMode::Final | AggregateMode::FinalPartitioned
- if self.group_by.expr.is_empty() =>
+ if self.group_by.is_true_no_grouping() =>
Review Comment:
Verified the fix - expr.is_empty() is correct here since GROUPING SETS(())
produces one row regardless of has_grouping_set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
