kumarUjjawal commented on issue #14431:
URL: https://github.com/apache/datafusion/issues/14431#issuecomment-3649191348
@eliaperantoni I was planning to work on this, I have already made progress,
my inital plan is:
- Add span storage to ScalarFunction/AggregateFunction and plumb it from
the SQL parser to the coercion layer.
- Adjust pattern matches/constructors across planner/optimizer/unparser to
compile with the new fields.
- Wrap the coercion errors with diagnostics using those spans and add
tests for both scalar and aggregate cases.
My only question was making all these changes will require touching several
files, would that be appropriate for this issue. Because Without adding spans
to function expressions, we’d be guessing locations and couldn’t meet the goal
of highlighting the SQL source.
Let me know if you have any other feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
