timsaucer commented on PR #19305: URL: https://github.com/apache/datafusion/pull/19305#issuecomment-3651114626
Thank you for the PR. The description says the unit tests were extended to include this work, but I don't see them in the diff. Also it looks like most of the structs are not implemented, so I suspect this will break across different compilers/libraries. There is some documentation in the README to describe the difficulties in working with FFI across the unstable bounds, and I think this approach doesn't have the necessary coverage. I'm converting the issue to draft just to make sure it doesn't merge as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
