alamb commented on code in PR #19313: URL: https://github.com/apache/datafusion/pull/19313#discussion_r2620893102
########## docs/source/library-user-guide/upgrading.md: ########## @@ -57,6 +57,40 @@ See <https://github.com/apache/datafusion/issues/19056> for more details. Note that the internal API has changed to use a trait `ListFilesCache` instead of a type alias. +### `newlines_in_values` moved from `FileScanConfig` to `CsvOptions` Review Comment: 👌 ########## datafusion/datasource/src/file_scan_config.rs: ########## @@ -913,17 +895,6 @@ impl FileScanConfig { props.constraints().clone() } - /// Specifies whether newlines in (quoted) values are supported. Review Comment: In order to help upgrades, I suggest leaving this function in (but marked as deprecated) and return always 'false' to try and hint to people towards the csv configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
