rluvaton commented on code in PR #19287:
URL: https://github.com/apache/datafusion/pull/19287#discussion_r2625044143
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -1127,16 +1159,31 @@ impl GroupedHashAggregateStream {
self.clear_shrink(&RecordBatch::new_empty(s));
}
+ /// Determines if groups are currently available to emit
+ fn can_emit(&self) -> bool {
+ match self.oom_mode {
Review Comment:
I think we should either rename the function or the oom_mode
as can_emit doesn't sound like related to oom,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
