alamb commented on code in PR #19344:
URL: https://github.com/apache/datafusion/pull/19344#discussion_r2628913686
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes_view.rs:
##########
@@ -226,14 +249,26 @@ impl<B: ByteViewType> ByteViewGroupValueBuilder<B> {
let exist_null = self.nulls.is_null(lhs_row);
let input_null = array.is_null(rhs_row);
if let Some(result) = nulls_equal_to(exist_null, input_null) {
- return result;
+ result
+ } else {
+ self.do_equal_to_inner_values_only(lhs_row, array, rhs_row)
Review Comment:
Let's move this conversation to
https://github.com/apache/datafusion/pull/19364
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes_view.rs:
##########
@@ -226,14 +249,26 @@ impl<B: ByteViewType> ByteViewGroupValueBuilder<B> {
let exist_null = self.nulls.is_null(lhs_row);
let input_null = array.is_null(rhs_row);
if let Some(result) = nulls_equal_to(exist_null, input_null) {
- return result;
+ result
+ } else {
+ self.do_equal_to_inner_values_only(lhs_row, array, rhs_row)
Review Comment:
I will give it a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
